Updates instructions for Docker#626
Merged
Merged
Conversation
conniey
requested review from
JonathanCrd,
KarishmaGhiya,
fanyang-mono,
jongio,
joshfree and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Docker documentation to provide clearer instructions for local development and Azure Entra ID authentication. The changes focus on improving consistency and adding missing authentication scenarios.
- Updated Docker build commands to require the ServerName parameter
- Added comprehensive instructions for using Azure Entra ID with Docker containers
- Corrected Docker image paths and improved documentation clarity
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/TROUBLESHOOTING.md | Added new section for Azure Entra ID Docker authentication with Windows-specific workarounds |
| servers/Azure.Mcp.Server/README.md | Simplified Docker instructions and corrected file path references |
| eng/scripts/Build-Docker.ps1 | Made ServerName parameter mandatory for Docker builds |
| CONTRIBUTING.md | Updated Docker build command examples to include required ServerName parameter |
| AGENTS.md | Updated Docker build commands and image references for consistency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
joshfree
approved these changes
Sep 30, 2025
alzimmermsft
approved these changes
Sep 30, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
This was referenced Sep 17, 2025
Closed
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Fix Docker build instructions. Make ServerName mandatory. * Update README and TROUBLESHOOTING. * Move to single line. * Update servers/Azure.Mcp.Server/TROUBLESHOOTING.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add preamble and link to TROUBLESHOOTING --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GitHub issue number?
N/A
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline