Remove unnecessary DI registration for IMcpServerProvider instance#644
Merged
joshfree merged 1 commit intomicrosoft:mainfrom Oct 1, 2025
Merged
Conversation
anuchandy
requested review from
JasonYeMSFT,
KarishmaGhiya,
alzimmermsft,
Copilot,
jongio,
tmeschter,
vukelich and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary dependency injection registrations for CommandGroupServerProvider and RegistryServerProvider classes that are directly instantiated by their respective discovery strategies rather than being resolved from the DI container.
- Removed DI registrations for
CommandGroupServerProviderandRegistryServerProvider
Member
|
Can you add an entry to the CHANGELOG.md that passes the "drunk grandma" test? |
anuchandy
force-pushed
the
no-need-provider-register
branch
from
a630c99 to
9b2aa4c
Compare
joshfree
approved these changes
Oct 1, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]The
CommandGroupServerProviderandRegistryServerProviderare instantiated byCommandGroupDiscoveryStrategyandRegistryDiscoveryStrategyduring the discovery phase, so there’s no need to register these provider types with the DI container.[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline