Update ExecuteSingleResourceQueryAsync references to include parameter names#729
Merged
JonathanCrd merged 5 commits intomicrosoft:mainfrom Oct 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes parameter passing issues in ExecuteSingleResourceQueryAsync method calls across multiple Azure MCP tools. The issue occurred when the additionalFilter parameter was being passed as tableName after a recent parameter was introduced, causing BadRequest errors in EventHubs and Azure Container Registry tools.
- Added explicit parameter names to all
ExecuteSingleResourceQueryAsynccalls to prevent positional parameter mismatches - Fixed the parameter ordering issue that was causing
additionalFiltervalues to be incorrectly passed astableName - Applied the fix consistently across six Azure tool services to prevent future breakage
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Storage/src/Services/StorageService.cs | Added explicit parameter names to ExecuteSingleResourceQueryAsync call for storage account queries |
| tools/Azure.Mcp.Tools.Sql/src/Services/SqlService.cs | Added explicit parameter names to ExecuteSingleResourceQueryAsync call for SQL database queries |
| tools/Azure.Mcp.Tools.Kusto/src/Services/KustoService.cs | Added explicit parameter names to ExecuteSingleResourceQueryAsync call for Kusto cluster queries |
| tools/Azure.Mcp.Tools.EventHubs/src/Services/EventHubsService.cs | Fixed parameter order by adding explicit names to ExecuteSingleResourceQueryAsync call for EventHubs namespace queries |
| tools/Azure.Mcp.Tools.AppConfig/src/Services/AppConfigService.cs | Added explicit parameter names to ExecuteSingleResourceQueryAsync call for App Configuration store queries |
| tools/Azure.Mcp.Tools.Acr/src/Services/AcrService.cs | Fixed parameter order by adding explicit names to ExecuteSingleResourceQueryAsync call for ACR registry queries |
| servers/Azure.Mcp.Server/CHANGELOG.md | Updated changelog to document the fix for BadRequest errors in ACR and EventHubs |
joshfree
approved these changes
Oct 7, 2025
jairmyree
approved these changes
Oct 7, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
…r names (microsoft#729) * Add additionalFilter parameter name to GetRegistry and GetNamespace methods * Update changelog * Specify parameters names on all references * Add PR to changelog * Fix typo in changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a problem for EventHubs and ACR where the
additionalFiltervalue was being passed astableNameafter this last parameter was introduced in PR #607.I explicitly specified all parameter names as well, to prevent these references from breaking in the future if new parameters are added.
GitHub issue number?
Fixes #727
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline