Merged
Conversation
xiangyan99
requested review from
JasonYeMSFT,
JonathanCrd,
KarishmaGhiya,
conniey,
Copilot,
jongio,
sandeep-sen and
vukelich
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the elicitation (user confirmation) feature that stopped working after the default tool loading behavior was changed in #704 to execute namespace tool calls directly instead of spawning separate child processes.
Key Changes:
- Adds elicitation support to
NamespaceToolLoaderby implementing security checks for tools marked as handling sensitive data - Includes unit tests to verify elicitation handler creation and validation
- Updates CHANGELOG.md to document the bug fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG.md | Documents the elicitation bug fix |
| NamespaceToolLoaderTests.cs | Adds unit tests for elicitation handler functionality in NamespaceToolLoader |
| NamespaceToolLoader.cs | Implements elicitation security checks for sensitive tools before execution |
vcolin7
reviewed
Oct 15, 2025
joshfree
approved these changes
Oct 15, 2025
joshfree
added
server-Azure.Mcp
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Fix elicitation * update * update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]#824
[Any additional context, screenshots, or information that helps reviewers]We changed the default tool loading behavior to execute namespace tool calls directly instead of spawning separate child processes for each namespace in #704.
Fix the elicitation support accordingly.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline