Use SetTag instead of AddTag when updating field values.#837
Merged
conniey merged 5 commits intomicrosoft:mainfrom Oct 16, 2025
Merged
Use SetTag instead of AddTag when updating field values.#837conniey merged 5 commits intomicrosoft:mainfrom
conniey merged 5 commits intomicrosoft:mainfrom
Conversation
conniey
requested review from
JonathanCrd,
KarishmaGhiya,
jairmyree,
jongio,
msalaman,
sandeep-sen and
vukelich
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a telemetry bug where all telemetry items incorrectly appeared as "IsServerCommandInvoked" = "true" and updates the tool name tracking for namespace mode invocations.
Key Changes:
- Replaced
AddTagwithSetTagto properly update telemetry tag values instead of appending duplicates - Added
ToolNametag update inNamespaceToolLoaderto correctly track child tool invocations when not spawning new processes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
SingleProxyToolLoader.cs |
Changed AddTag to SetTag for IsServerCommandInvoked tag to fix duplicate tag issue |
ServerToolLoader.cs |
Changed AddTag to SetTag for IsServerCommandInvoked tag to fix duplicate tag issue |
NamespaceToolLoader.cs |
Changed AddTag to SetTag and added ToolName tag update to properly track child tool names in namespace mode |
conniey
force-pushed
the
telemetry-set-tag-instead-of-add
branch
from
cdcd671 to
83e1dbf
Compare
alzimmermsft
approved these changes
Oct 16, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
anuchandy
approved these changes
Oct 16, 2025
…y-set-tag-instead-of-add
alzimmermsft
approved these changes
Oct 16, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Update to use SetTag rather than AddTag * Add documentation * Add CHANGELOG * Fix spelling error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem All telemetry items appear as "IsServerCommandInvoked" = "true".
The issue was that using
AddTagwould append a new KVP to the telemetry Tags rather than replace an existing KVP of the same name. Only the first matching KVP of the same name was being pulled in.Problem Before, invoking a child tool in namespace mode would spawn a new process. This new process would create its own telemetry service. This new telemetry service would add another telemetry item with the tool name "blob_list".
Since we no longer spawn a child process, we need to associate the "command" in the NamespaceToolLoader with what the ToolName.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline