Investigation into setting IsServerCommandInvoked more locally#874
Merged
alzimmermsft merged 4 commits intomicrosoft:mainfrom Oct 20, 2025
Merged
Conversation
alzimmermsft
requested review from
JasonYeMSFT,
Copilot,
fanyang-mono,
jongio,
joshfree,
tmeschter,
vukelich and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors telemetry instrumentation to set the IsServerCommandInvoked tag closer to where command execution decisions are made, rather than assuming all calls invoke server commands by default. The changes improve accuracy by setting the tag within specific execution paths (learn mode vs command mode) across multiple tool loader implementations.
Key changes:
- Removed premature/default telemetry tag setting from
McpRuntimeand tool loader entry points - Added explicit telemetry tag setting in learn mode methods (
false) and command execution methods (true) - Minor code modernization (collection expressions, lambda parameter simplification)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
TelemetryService.cs |
Modernized collection syntax using collection expressions and removed unused imports |
CommandFactory.cs |
Simplified lambda parameter names to use type inference |
SingleProxyToolLoader.cs |
Moved IsServerCommandInvoked telemetry tag from entry point to specific execution path methods |
ServerToolLoader.cs |
Relocated telemetry tag setting from conditional block to actual command invocation point |
NamespaceToolLoader.cs |
Moved telemetry tag assignment from learn mode check to command execution method |
McpRuntime.cs |
Removed default assumption that all tool calls invoke server commands |
conniey
approved these changes
Oct 20, 2025
Member
conniey
left a comment
conniey
left a comment
There was a problem hiding this comment.
CHANGELOG comment in "Other changes"?
I was thinking about how to test these code paths in unit tests but could not figure out anything reasonable. Hmm
conniey
approved these changes
Oct 20, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
…soft#874) * Investigation into setting IsServerCommandInvoked more locally * Fix linting * CHANGELOG entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline