Fix Foundry Serialization issue.#904
Merged
g2vinay merged 3 commits intomicrosoft:mainfrom Oct 23, 2025
Merged
Conversation
joshfree
added
bug
anuchandy
reviewed
Oct 23, 2025
g2vinay
requested review from
JasonYeMSFT,
JonathanCrd,
Copilot,
fanyang-mono,
jairmyree,
jongio and
joshfree
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a serialization issue in the Foundry service by replacing the generic JSON serialization approach with a properly configured source-generated JSON context. The change ensures AOT-safe serialization of tool definitions.
Key Changes:
- Replaced dynamic type info retrieval with source-generated JSON serialization context
- Added missing type registrations to
FoundryJsonContextforToolDefinitionAIFunctionand its list type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Foundry/src/Services/FoundryService.cs | Updated serialization call to use FoundryJsonContext instead of dynamic type info |
| tools/Azure.Mcp.Tools.Foundry/src/Commands/FoundryJsonContext.cs | Added JSON serializable attributes for ToolDefinitionAIFunction types and required namespace import |
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #621 foundry serialization issue.