Fix to create and update sql db with correct sku parameters when provided#925
Merged
Fix to create and update sql db with correct sku parameters when provided#925
Conversation
achyuth-ms
requested review from
a team,
ericshape,
jeremyfrosti and
mitesh-pv
as code owners
achyuth-ms
requested review from
chidozieononiwu,
conniey,
g2vinay,
hallipr,
jairmyree,
joshfree and
msalaman
achyuth-ms
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes SKU parameter handling in SQL database create and update commands to correctly use user-provided SKU values. The fix addresses issue #856 by ensuring that when users specify SKU parameters (name, tier, capacity), they are properly applied instead of being overridden by existing database values during updates.
Key changes:
- Modified SKU parameter binding to use proper option names instead of constant strings
- Updated SKU handling logic in
UpdateDatabaseAsyncto reset conflicting properties when SKU name changes - Added comprehensive unit tests covering various SKU tier transitions (Basic, Standard, Premium)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SqlOptionDefinitions.cs | Changed ZoneRedundant option type from bool to bool? to support nullable values |
| DatabaseCreateCommand.cs | Fixed option binding to use .Name property from option definitions instead of string constants |
| DatabaseUpdateCommand.cs | Fixed option binding to use .Name property from option definitions instead of string constants |
| SqlService.cs | Updated SKU update logic to properly reset tier/capacity/family/size when SKU name changes, and added logging for SKU configuration |
| DatabaseCreateCommandTests.cs | Added tests for database creation with null, Basic, Standard, and Premium SKU values |
| DatabaseUpdateCommandTests.cs | Added tests for authorization failures and various SKU tier update scenarios |
achyuth-ms
force-pushed
the
operationprompts
branch
from
efbc1a2 to
f3f2750
Compare
Member
Author
|
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ericshape
reviewed
Oct 22, 2025
Member
|
it seems all the pipeline passed. |
ericshape
reviewed
Oct 22, 2025
ericshape
approved these changes
Oct 22, 2025
Member
ericshape
left a comment
ericshape
left a comment
There was a problem hiding this comment.
please rebase and ask MCP reviewer to review
joshfree
approved these changes
Oct 23, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure MCP Server
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix to create and update sql db with correct sku parameters when provided by user
Commands:
azmcp sql database createazmcp sql database updateGitHub issue number?
#856
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline