Fix: Dynamically extract resourceType to prevent 400 Bad Request error#22
Open
0xharkirat wants to merge 3 commits intomicrosoft:mainfrom
Open
Fix: Dynamically extract resourceType to prevent 400 Bad Request error#220xharkirat wants to merge 3 commits intomicrosoft:mainfrom
0xharkirat wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Dynamically extract resourceType from existing configuration instead of hardcoding it as 'AzureSolutionTemplatePackageConfiguration'. This fixes the 400 Bad Request error when the package configuration uses a different resource type.
Author
|
Any feedback guys? |
Author
|
Hi Guys, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation hardcodes
"resourceType": "AzureSolutionTemplatePackageConfiguration"in theapplication_generateUpdatePackageReferenceRequestBody()function. This causes a 400 Bad Request error when the package configuration uses a different resource type (e.g.,AzureApplicationPackageConfiguration).Error Details
When running the workflow, the API returns:
Solution
This PR modifies the
application_generateUpdatePackageReferenceRequestBody()function to:resourceTypefrom the existing$configurationvariable (which contains the current package configuration)jqto preserve the originalresourceTypeandidfields while updating only theversionandpackageReferencesChanges Made
jqtransformationresourceTypeandidare now preserved from the existing configurationversionandpackageReferencesare updated with new valuesBefore
After
Benefits
resourceType(e.g.,AzureSolutionTemplatePackageConfiguration,AzureApplicationPackageConfiguration)Testing
Tested with workflows that use different resource types and confirmed the 400 error is resolved.
Closes #21