Fix #264: enforce init-only contract on immutable records#274
Merged
Conversation
Add reflection-based regression test verifying TrayIconSpec, WindowSpec, Command, and Command<T> properties use init (not set). Update doc comments to say 'init-only' explicitly so tools that render init as set won't mislead reviewers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The source code was already correct —
TrayIconSpec,WindowSpec,Command, andCommand<T>all useinit-only properties. The external API review tool likely renderedinitassetbecause at the IL levelinitis asetmethod withmodreq(IsExternalInit).Changes
New test:
tests/Reactor.Tests/ImmutableRecordContractTests.cs— reflection-based regression test that verifies all public settable properties on the four record types carry theIsExternalInitmodifier (i.e., are trulyinit-only). Prevents future regressions.Doc comment updates: Changed "Immutable" to "Immutable (init-only)" in XML summary tags on all four types, making the contract unambiguous even to tools that cannot distinguish
initfromset.Test results
All 8 new theory cases pass (4 types × 2 assertions each).
Closes #264.