Fix High Contrast color mappings for buttons

[YuliKl]

Describe the bug
The following controls don't have the most intuitive color mappings when they're drawn in High Contrast.

• ToggleSplitButton
• Button
• ToggleButton

The current mapping may confuse users, especially if they customize the colors of their HC theme. We should correct these mappings, particularly for the new styles, but would not be amiss to apply the same fix to the older styles as well.

Requested changes

When applying this custom HC theme

the controls should look like the following.

ToggleSplitButton

Needed changes:
ToggleSplitButton (OFF)
Rest

• Chevron - SystemColorButtonTextColor


Hover

• Chevron - SystemColorButtonTextColor
• Main Button Base - SystemColorHighlightTextColor

Pressed

• Chevron - SystemColorButtonTextColor
• Main Button Base - SystemColorHighlightTextColor
• Main Button Stroke -SystemColorHighlightTextColor

ToggleSplitButton (ON)

Hover

• Main Button Base - SystemColorButtonTextColor
• Main Button Stroke - SystemColorButtonTextColor
• Main Button Label - SystemColorButtonFaceColor

Pressed

• Main Button Base - SystemColorButtonFaceColor
• Main Button Stroke - SystemColorButtonFaceColor
• Main Button Label - SystemColorButtonTextColor

Button

Needed changes:
Hover

• Button Base - SystemColorHighlightTextColor

Pressed

• Button Base - SystemColorHighlightTextColor
• Button Stroke -SystemColorHighlightTextColor

ToggleButton

Needed changes:
ToggleButton (OFF)
Hover

• Base Fill - SystemColorHighlightTextColor

Pressed

• Base Fill - SystemColorHighlightTextColor
• Base Stroke - SystemColorHighlightTextColor

ToggleButton (ON)
Hover

• Text label - SystemColorButtonFaceColor
• Base Fill - SystemColorButtonTextColor
• Base Stroke - SystemColorButtonTextColor

Pressed

• Base Fill - SystemColorHighlightTextColor
• Base Stroke - SystemColorHighlightTextColor

Additional context

Copied from internal bug

[StephenLPeters]

@chingucoding want to take a look? :)

[marcelwgn]

Sure thing!