Refactoring bug, searches stats field

[bazineta]

There appears to be bug in the 'searches' stat as a result of 56aba08.

It's here:

mimalloc/src/stats.c

Line 238 in 09a2709

const int64_t avg_tens = (stat->total == 0 ? 0 : (stat->total*10 / stat->total));

const int64_t avg_tens = (stat->total == 0 ? 0 : (stat->total*10 / stat->total));

If total is zero, then avg_tens is 0. If total is non-zero, avg_tens is 10; we're multiplying total by 10 and dividing it by itself.

Prior to the refactoring in that commit, the searches field was a tuple, containing a count and a total, and the math used to be:

const int64_t avg_tens = (stat->count == 0 ? 0 : (stat->total*10 / stat->count));

@daanx Not sure what the correct course of action is here -- should this be divided by some other field now?

[bazineta]

@daanx I believe the point of this particular counter was to facilitate a running average, i.e., stuff per iteration. To that end, I've experimented with an additional type in mimalloc-stats.h:

typedef struct mi_stat_average_s {      
  int64_t total;
  int64_t count;
} mi_stat_average_t;

And added the requisite functions and macros; the average computation then becomes straightforward, basically, returning to as it was before the refactoring.

Obviously, that's an incompatible change to the stats structure, so it'd have to be revved to 3. Other than that, the changes are an easy lift and seem to test properly.

[bazineta]

@daanx I have a well-tested change closing this and #1151, but it's against the dev3 branch, and I see that PRs must be against dev. Unsure as to how to proceed in this case.