v3.2.6 released, test on Android please

[daanx]

I just released an update to v3 as v3.2.6. This has "true" first-class heaps that can be used from any thread to allocate on. It also has improved the thread-local access (especially on Windows), but this is not yet tested on Android. If anyone can try v3.2.6 on Android and report back that would be great.

• On Android, the default is currently to use thread locals but that used to have problems with recursion during initialization. If you run into trouble, please modify include\mimalloc\prim.h, line 359, to uncomment the // || defined(__ANDROID__) clause to try if it works with pthreads (as before).
• On macOS we now use slots 108 and 109 as it seems on the latest releases "our" slot 89 is now used by Apple again. Hopefully, 108/109 are unused but let me know if you run into issues.

Thanks! Daan

[Axiom415]

Hi, I'm sorry this isn't Android testing, but I'd like to report a problem of building v3.2.6.

I've tried with clang 21.1.8 with GNU front-end (not clang-cl), with these CMake command

CMake command

cmake -G Ninja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Release

-- The C compiler identification is Clang 21.1.8 with GNU-like command-line
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/18/BuildTools/VC/Tools/Llvm/x64/bin/clang.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
--
-- Architecture: x64
-- Override standard malloc (MI_OVERRIDE=ON)
--
-- Library name     : mimalloc
-- Version          : 3.2.6
-- Build type       : release
-- C Compiler       : C:/Program Files (x86)/Microsoft Visual Studio/18/BuildTools/VC/Tools/Llvm/x64/bin/clang.exe
-- Compiler flags   : -Wall;-Wextra;-Wpedantic;-Wno-unknown-pragmas;-fvisibility=hidden;-Wstrict-prototypes;-Wno-static-in-inline;-ftls-model=initial-exec;-fno-builtin-malloc
-- Compiler defines : MI_CMAKE_BUILD_TYPE=release;MI_BUILD_RELEASE
-- Link libraries   : psapi;shell32;user32;advapi32;bcrypt
-- Build targets    : shared;static;object;tests
--
-- Configuring done (2.1s)
-- Generating done (0.1s)

And then it throws out these error

Build error

ninja
[2/48] Building C object CMakeFiles/mimalloc.dir/src/arena.c.obj
FAILED: [code=1] CMakeFiles/mimalloc.dir/src/arena.c.obj
C:\PROGRA~2\MICROS~2\18\BUILDT~1\VC\Tools\Llvm\x64\bin\clang.exe -DMI_BUILD_RELEASE -DMI_CMAKE_BUILD_TYPE=release -DMI_MALLOC_OVERRIDE -DMI_SHARED_LIB -DMI_SHARED_LIB_EXPORT -Dmimalloc_EXPORTS -ID:/mimalloc-3.2.6/include -O3 -DNDEBUG -std=gnu11 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wextra -Wpedantic -Wno-unknown-pragmas -fvisibility=hidden -Wstrict-prototypes -Wno-static-in-inline -ftls-model=initial-exec -fno-builtin-malloc -MD -MT CMakeFiles/mimalloc.dir/src/arena.c.obj -MF CMakeFiles\mimalloc.dir\src\arena.c.obj.d -o CMakeFiles/mimalloc.dir/src/arena.c.obj -c D:/mimalloc-3.2.6/src/arena.c
D:/mimalloc-3.2.6/src/arena.c:598:33: warning: incompatible pointer types passing 'mi_arena_pages_t **' (aka 'struct mi_arena_pages_s **') to parameter of type 'const uintptr_t *' (aka 'const unsigned long long *') [-Wincompatible-pointer-types]
  598 |   return mi_atomic_load_relaxed(&heap->arena_pages[arena->arena_idx]);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:72:75: note: expanded from macro 'mi_atomic_load_relaxed'
   72 | #define mi_atomic_load_relaxed(p)                mi_atomic(load_explicit)(p,mi_memory_order(relaxed))
      |                                                                           ^
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:220:75: note: passing argument to parameter 'p' here
  220 | static inline uintptr_t mi_atomic_load_explicit(_Atomic(uintptr_t) const* p, mi_memory_order mo) {
      |                                                                           ^
D:/mimalloc-3.2.6/src/arena.c:598:10: error: incompatible integer to pointer conversion returning 'uintptr_t' (aka 'unsigned long long') from a function with result type 'mi_arena_pages_t *' (aka 'struct mi_arena_pages_s *') [-Wint-conversion]
  598 |   return mi_atomic_load_relaxed(&heap->arena_pages[arena->arena_idx]);
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:72:50: note: expanded from macro 'mi_atomic_load_relaxed'
   72 | #define mi_atomic_load_relaxed(p)                mi_atomic(load_explicit)(p,mi_memory_order(relaxed))
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:48:35: note: expanded from macro 'mi_atomic'
   48 | #define  mi_atomic(name)          mi_atomic_##name
      |                                   ^
<scratch space>:5:1: note: expanded from here
    5 | mi_atomic_load_explicit
      | ^
D:/mimalloc-3.2.6/src/arena.c:622:44: warning: incompatible pointer types passing 'mi_arena_pages_t **' (aka 'struct mi_arena_pages_s **') to parameter of type 'const uintptr_t *' (aka 'const unsigned long long *') [-Wincompatible-pointer-types]
  622 |       arena_pages = mi_atomic_load_acquire(&heap->arena_pages[arena->arena_idx]);
      |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:71:75: note: expanded from macro 'mi_atomic_load_acquire'
   71 | #define mi_atomic_load_acquire(p)                mi_atomic(load_explicit)(p,mi_memory_order(acquire))
      |                                                                           ^
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:220:75: note: passing argument to parameter 'p' here
  220 | static inline uintptr_t mi_atomic_load_explicit(_Atomic(uintptr_t) const* p, mi_memory_order mo) {
      |                                                                           ^
D:/mimalloc-3.2.6/src/arena.c:622:19: error: incompatible integer to pointer conversion assigning to 'mi_arena_pages_t *' (aka 'struct mi_arena_pages_s *') from 'uintptr_t' (aka 'unsigned long long') [-Wint-conversion]
  622 |       arena_pages = mi_atomic_load_acquire(&heap->arena_pages[arena->arena_idx]);
      |                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/src/arena.c:633:33: warning: incompatible pointer types passing 'mi_arena_pages_t **' (aka 'struct mi_arena_pages_s **') to parameter of type 'uintptr_t *' (aka 'unsigned long long *') [-Wincompatible-pointer-types]
  633 |         mi_atomic_store_release(&heap->arena_pages[arena->arena_idx], arena_pages);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:73:76: note: expanded from macro 'mi_atomic_store_release'
   73 | #define mi_atomic_store_release(p,x)             mi_atomic(store_explicit)(p,x,mi_memory_order(release))
      |                                                                            ^
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:232:64: note: passing argument to parameter 'p' here
  232 | static inline void mi_atomic_store_explicit(_Atomic(uintptr_t)*p, uintptr_t x, mi_memory_order mo) {
      |                                                                ^
D:/mimalloc-3.2.6/src/arena.c:633:71: error: incompatible pointer to integer conversion passing 'mi_arena_pages_t *' (aka 'struct mi_arena_pages_s *') to parameter of type 'uintptr_t' (aka 'unsigned long long') [-Wint-conversion]
  633 |         mi_atomic_store_release(&heap->arena_pages[arena->arena_idx], arena_pages);
      |                                                                       ^~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:232:77: note: passing argument to parameter 'x' here
  232 | static inline void mi_atomic_store_explicit(_Atomic(uintptr_t)*p, uintptr_t x, mi_memory_order mo) {
      |                                                                             ^
3 warnings and 3 errors generated.
[5/48] Building C object CMakeFiles/mimalloc.dir/src/alloc.c.obj
D:/mimalloc-3.2.6/src/alloc.c:623:44: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  623 | static std_new_handler_t mi_get_new_handler() {
      |                                            ^
      |                                             void
1 warning generated.
[7/48] Building C object CMakeFiles/mimalloc.dir/src/heap.c.obj
FAILED: [code=1] CMakeFiles/mimalloc.dir/src/heap.c.obj
C:\PROGRA~2\MICROS~2\18\BUILDT~1\VC\Tools\Llvm\x64\bin\clang.exe -DMI_BUILD_RELEASE -DMI_CMAKE_BUILD_TYPE=release -DMI_MALLOC_OVERRIDE -DMI_SHARED_LIB -DMI_SHARED_LIB_EXPORT -Dmimalloc_EXPORTS -ID:/mimalloc-3.2.6/include -O3 -DNDEBUG -std=gnu11 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wextra -Wpedantic -Wno-unknown-pragmas -fvisibility=hidden -Wstrict-prototypes -Wno-static-in-inline -ftls-model=initial-exec -fno-builtin-malloc -MD -MT CMakeFiles/mimalloc.dir/src/heap.c.obj -MF CMakeFiles\mimalloc.dir\src\heap.c.obj.d -o CMakeFiles/mimalloc.dir/src/heap.c.obj -c D:/mimalloc-3.2.6/src/heap.c
D:/mimalloc-3.2.6/src/heap.c:157:62: warning: incompatible pointer types passing 'mi_arena_pages_t **' (aka 'struct mi_arena_pages_s **') to parameter of type 'const uintptr_t *' (aka 'const unsigned long long *') [-Wincompatible-pointer-types]
  157 |       mi_arena_pages_t* arena_pages = mi_atomic_load_relaxed(&heap->arena_pages[i]);
      |                                                              ^~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:72:75: note: expanded from macro 'mi_atomic_load_relaxed'
   72 | #define mi_atomic_load_relaxed(p)                mi_atomic(load_explicit)(p,mi_memory_order(relaxed))
      |                                                                           ^
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:220:75: note: passing argument to parameter 'p' here
  220 | static inline uintptr_t mi_atomic_load_explicit(_Atomic(uintptr_t) const* p, mi_memory_order mo) {
      |                                                                           ^
D:/mimalloc-3.2.6/src/heap.c:157:25: error: incompatible integer to pointer conversion initializing 'mi_arena_pages_t *' (aka 'struct mi_arena_pages_s *') with an expression of type 'uintptr_t' (aka 'unsigned long long') [-Wint-conversion]
  157 |       mi_arena_pages_t* arena_pages = mi_atomic_load_relaxed(&heap->arena_pages[i]);
      |                         ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/src/heap.c:159:33: warning: incompatible pointer types passing 'mi_arena_pages_t **' (aka 'struct mi_arena_pages_s **') to parameter of type 'uintptr_t *' (aka 'unsigned long long *') [-Wincompatible-pointer-types]
  159 |         mi_atomic_store_relaxed(&heap->arena_pages[i], NULL);
      |                                 ^~~~~~~~~~~~~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:74:76: note: expanded from macro 'mi_atomic_store_relaxed'
   74 | #define mi_atomic_store_relaxed(p,x)             mi_atomic(store_explicit)(p,x,mi_memory_order(relaxed))
      |                                                                            ^
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:232:64: note: passing argument to parameter 'p' here
  232 | static inline void mi_atomic_store_explicit(_Atomic(uintptr_t)*p, uintptr_t x, mi_memory_order mo) {
      |                                                                ^
D:/mimalloc-3.2.6/src/heap.c:159:56: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'uintptr_t' (aka 'unsigned long long') [-Wint-conversion]
  159 |         mi_atomic_store_relaxed(&heap->arena_pages[i], NULL);
      |                                                        ^~~~
C:\Program Files\LLVM\lib\clang\21\include\__stddef_null.h:26:14: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |              ^~~~~~~~~~
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:74:78: note: expanded from macro 'mi_atomic_store_relaxed'
   74 | #define mi_atomic_store_relaxed(p,x)             mi_atomic(store_explicit)(p,x,mi_memory_order(relaxed))
      |                                                                              ^
D:/mimalloc-3.2.6/include\mimalloc\atomic.h:232:77: note: passing argument to parameter 'x' here
  232 | static inline void mi_atomic_store_explicit(_Atomic(uintptr_t)*p, uintptr_t x, mi_memory_order mo) {
      |                                                                             ^
2 warnings and 2 errors generated.
ninja: build stopped: subcommand failed.

And this only happens in GNU-frontend, if I tried it with clang-cl, it builds fine.

[daanx]

Thanks @Axiom415 ! -- I pushed a fix to the latest dev3 branch; do you think you can try it out and see if it now works for you as well? (if so, I'll release v3.2.7 rc2 soon :-) )

[Axiom415]

Thanks Daan! It builds succesfully with both front-ends.

[daanx]

Thanks for testing!

[bazineta]

No issues during testing of 3.2.6 on OSX and Linux.

I do note that the mi_stats_merge() function is no longer present; I presume it to be no longer required.

[rossbridger]

I was trying to integrating mimalloc into o3de, and upgrading mimalloc to 3.2.6 causes its dynamic libraries to fail to load on windows (https://github.com/o3de/o3de/actions/runs/21021263570/job/60502803428)