Ensure correct size_t mangling on Emscripten#1257
Closed
kleisauke wants to merge 1 commit intomicrosoft:dev3from
Closed
Ensure correct size_t mangling on Emscripten#1257kleisauke wants to merge 1 commit intomicrosoft:dev3from
size_t mangling on Emscripten#1257kleisauke wants to merge 1 commit intomicrosoft:dev3from
Conversation
Emscripten defines `size_t` as `unsigned long` for both wasm32 and wasm64, mangling must therefore use `m` (Itanium ABI), independent of the pointer size.
daanx
added a commit
that referenced
this pull request
Apr 12, 2026
Collaborator
|
Hallo, bedankt voor de PR :-) However, I think we can just add the condition |
daanx
added a commit
that referenced
this pull request
Apr 12, 2026
Contributor
Author
|
Great, that works for me! 👍 I initially thought consolidating these pre-processor branches would would simplify things, especially since some toolchains (like llvm-mingw) require |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten defines
size_tasunsigned longfor both wasm32 and wasm64, mangling must therefore usem(Itanium ABI), independent of the pointer size.Details
See also: emscripten-core/emscripten#5916.