Closed
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Mar 20, 2023
Author
jsoref
left a comment
jsoref
left a comment
There was a problem hiding this comment.
Most spelling corrections suggestions automatically suggested by Google Sheets. All fault mine
| /*! \page build Building | ||
|
|
||
| Checkout the sources from Github: | ||
| Checkout the sources from GitHub: |
| </div><!--header--> | ||
| <div class="contents"> | ||
| <div class="textblock"><p>Checkout the sources from Github: </p><div class="fragment"><div class="line">git clone https:<span class="comment">//github.com/microsoft/mimalloc</span></div> | ||
| <div class="textblock"><p>Checkout the sources from GitHub: </p><div class="fragment"><div class="line">git clone https://github.com/microsoft/mimalloc</div> |
Author
There was a problem hiding this comment.
I'm uncertain about why the clone url was corrupted, but it seems undesirable.
| int32_t cpu_info[4]; | ||
| __cpuid(cpu_info, 7); | ||
| _mi_cpu_has_fsrm = ((cpu_info[3] & (1 << 4)) != 0); // bit 4 of EDX : see <https ://en.wikipedia.org/wiki/CPUID#EAX=7,_ECX=0:_Extended_Features> | ||
| _mi_cpu_has_fsrm = ((cpu_info[3] & (1 << 4)) != 0); // bit 4 of EDX : see <https://en.wikipedia.org/wiki/CPUID#EAX=7,_ECX=0:_Extended_Features> |
Author
There was a problem hiding this comment.
This corruption also seems undesirable
| } | ||
| #elif !defined(MI_USE_ENVIRON) || (MI_USE_ENVIRON!=0) | ||
| // On Posix systemsr use `environ` to acces environment variables | ||
| // On Posix systemsr use `environ` to access environment variables |
Author
There was a problem hiding this comment.
acces is often a posix thing, but, here it appears to just be a typo
| transferring objects between threads. It tries to reflect real-world workloads: | ||
| - allocation size is distributed linearly in powers of two | ||
| - with some fraction extra large (and some extra extra large) | ||
| - with some fraction extra large (and some extra, extra, large) |
Author
There was a problem hiding this comment.
these commas are a grammatical thing which coincidentally mean that the duplicate word detection doesn't complain...
daanx
added a commit
that referenced
this pull request
Mar 29, 2023
daanx
added a commit
that referenced
this pull request
Apr 21, 2024
Collaborator
|
Thanks so much! I went through it and applied manually since the source diverged so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/mimalloc/actions/runs/4463465974#summary-12116021728
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/mimalloc/actions/runs/4463466056#summary-12116021920