Skip to content

Documentation Update and Docker fix#87

Merged
sbaidachni merged 64 commits into
developmentfrom
sbaidachni/docker_docs
Mar 3, 2026
Merged

Documentation Update and Docker fix#87
sbaidachni merged 64 commits into
developmentfrom
sbaidachni/docker_docs

Conversation

@sbaidachni
Copy link
Copy Markdown
Contributor

@sbaidachni sbaidachni commented Feb 19, 2025

All services are working using User-assigned managed identity.
A separate identity for GitHub has been introduced
Documentation has been updated
All pipelines are utilizing docker containers now
Updated parameters (including AI Foundry new uri notation)
Workflows validated for flex plan as well (with no slot support)
Images and references has been updated

@sbaidachni sbaidachni force-pushed the sbaidachni/docker_docs branch from 51ef0ba to 88da402 Compare May 23, 2025 19:00
@sbaidachni sbaidachni force-pushed the sbaidachni/docker_docs branch from 88da402 to f706fa4 Compare May 23, 2025 19:06
@sbaidachni
Copy link
Copy Markdown
Contributor Author

@copilot You need to fix this: ./src/custom_skills/VectorEmbed/init.py:17:121: E501 line too long (128 > 120 characters)
1 E501 line too long (128 > 120 characters)
1

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 2, 2026

@sbaidachni I've opened a new pull request, #97, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits March 2, 2026 20:01
Co-authored-by: sbaidachni <10055252+sbaidachni@users.noreply.github.com>
…-414d-919f-c32f4640b82d

[WIP] Update documentation and fix Docker configurations
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

Search Evaluation Results

Metric Value
AveragePrecision.average_precision 0.0
F1-score@10.f1_score_at_10 0.0
F1-score@3.f1_score_at_3 0.0
F1-score@5.f1_score_at_5 0.0
Precision@10.precision_at_10 0.0
Precision@3.precision_at_3 0.0
Precision@5.precision_at_5 0.0
Recall@10.recall_at_10 0.0
Recall@3.recall_at_3 0.0
Recall@5.recall_at_5 0.0
ReciprocalRank.reciprocal_rank 0.0

@sbaidachni
Copy link
Copy Markdown
Contributor Author

@copilot code review[agent] All the suggestions have been implemented. Please, review and approve

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 2, 2026

@sbaidachni I've opened a new pull request, #98, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

mlops/evaluation/search_evaluation.py:35

  • project_name is read from AI_FOUNDRY_PROJECT_URI and then passed into evaluate(...) as azure_ai_project. If the env var is unset, this will be None and will likely fail downstream with a less clear error. Add an explicit validation (and a helpful error message) before calling evaluate.
    project_name = os.environ.get("AI_FOUNDRY_PROJECT_URI")
    azure_search_service_name = os.environ.get("ACS_SERVICE_NAME")
    azure_search_endpoint = f"https://{azure_search_service_name}.search.windows.net"

    print(f"Running evaluation for index: {index_name}")
    print(f"Azure Search Endpoint {azure_search_endpoint}")
    print(f"Project Name {project_name}")


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread mlops/deployment_scripts/deploy_azure_functions.py
Comment thread mlops/deployment_scripts/deploy_azure_functions.py
@sbaidachni
Copy link
Copy Markdown
Contributor Author

@copilot Implement two proposed changes as a single PR

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 2, 2026

@sbaidachni I've opened a new pull request, #99, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits March 2, 2026 20:23
Co-authored-by: sbaidachni <10055252+sbaidachni@users.noreply.github.com>
…-42fb-b545-19ecaafd1b45

Add FileNotFoundError handling for missing az CLI in function deployment
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread mlops/evaluation/search_evaluation.py
Comment thread docs/ai_search_system_identity.md
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

Search Evaluation Results

Metric Value
AveragePrecision.average_precision 0.0
F1-score@10.f1_score_at_10 0.0
F1-score@3.f1_score_at_3 0.0
F1-score@5.f1_score_at_5 0.0
Precision@10.precision_at_10 0.0
Precision@3.precision_at_3 0.0
Precision@5.precision_at_5 0.0
Recall@10.recall_at_10 0.0
Recall@3.recall_at_3 0.0
Recall@5.recall_at_5 0.0
ReciprocalRank.reciprocal_rank 0.0

Copy link
Copy Markdown
Collaborator

@radiant-tangent radiant-tangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown

@anastasiyagromova anastasiyagromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@sbaidachni sbaidachni merged commit 1c9e807 into development Mar 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants