Documentation Update and Docker fix#87
Conversation
51ef0ba to
88da402
Compare
88da402 to
f706fa4
Compare
…/mlops-aisearch-pull into sbaidachni/docker_docs
|
@copilot You need to fix this: ./src/custom_skills/VectorEmbed/init.py:17:121: E501 line too long (128 > 120 characters) |
|
@sbaidachni I've opened a new pull request, #97, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: sbaidachni <10055252+sbaidachni@users.noreply.github.com>
…-414d-919f-c32f4640b82d [WIP] Update documentation and fix Docker configurations
Search Evaluation Results
|
|
@copilot code review[agent] All the suggestions have been implemented. Please, review and approve |
|
@sbaidachni I've opened a new pull request, #98, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
mlops/evaluation/search_evaluation.py:35
project_nameis read fromAI_FOUNDRY_PROJECT_URIand then passed intoevaluate(...)asazure_ai_project. If the env var is unset, this will beNoneand will likely fail downstream with a less clear error. Add an explicit validation (and a helpful error message) before callingevaluate.
project_name = os.environ.get("AI_FOUNDRY_PROJECT_URI")
azure_search_service_name = os.environ.get("ACS_SERVICE_NAME")
azure_search_endpoint = f"https://{azure_search_service_name}.search.windows.net"
print(f"Running evaluation for index: {index_name}")
print(f"Azure Search Endpoint {azure_search_endpoint}")
print(f"Project Name {project_name}")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot Implement two proposed changes as a single PR |
|
@sbaidachni I've opened a new pull request, #99, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: sbaidachni <10055252+sbaidachni@users.noreply.github.com>
…-42fb-b545-19ecaafd1b45 Add FileNotFoundError handling for missing az CLI in function deployment
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Search Evaluation Results
|
All services are working using User-assigned managed identity.
A separate identity for GitHub has been introduced
Documentation has been updated
All pipelines are utilizing docker containers now
Updated parameters (including AI Foundry new uri notation)
Workflows validated for flex plan as well (with no slot support)
Images and references has been updated