Fix golangci-lint compatibility with Go 1.26#430
Open
raghavendra-nataraj wants to merge 2 commits intomainfrom
Open
Fix golangci-lint compatibility with Go 1.26#430raghavendra-nataraj wants to merge 2 commits intomainfrom
raghavendra-nataraj wants to merge 2 commits intomainfrom
Conversation
Upgrade from golangci-lint v1 to v2 to fix the pre-existing CI lint failure where v1 (built with Go 1.25) cannot lint code targeting Go 1.26. Changes: - Migrate .golangci.yml to v2 format (version field, restructured config) - Update Makefile to install golangci-lint v2 import path Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
raghavendra-nataraj
force-pushed
the
fix/golangci-lint-go126-compat
branch
from
787f340 to
2872a12
Compare
Bump gRPC to v1.80.0 to address CG alert for authorization bypass CVE. Also updates x/net (v0.48.0->v0.49.0) and x/sys (v0.39.0->v0.40.0). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI lint job fails on \main\ because \golangci-lint v1\ (latest: v1.64.8, built with Go 1.25.9) cannot analyze code targeting Go 1.26:
\
level=error msg="Running error: can't run linter goanalysis_metalinter\ninspect: failed to load package grpc: could not load export data: no export data for "google.golang.org/grpc""
\\
This is a pre-existing issue on main — not caused by any recent change.
Fix
Upgrade from golangci-lint v1 to v2, which supports Go 1.26:
Context
This unblocks PR #429 (gRPC CVE fix) which also has the lint failure.