Skip to content

[master] Update dependencies from dotnet/arcade#5122

Merged
Forgind merged 3 commits into
masterfrom
darc-master-b93e3e2a-508b-42fd-8172-36c6b7c0d932
Feb 25, 2020
Merged

[master] Update dependencies from dotnet/arcade#5122
Forgind merged 3 commits into
masterfrom
darc-master-b93e3e2a-508b-42fd-8172-36c6b7c0d932

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 6ff1327c-3d7f-4d3f-41a4-08d667929bd9
  • Build: 20200224.2
  • Date Produced: 2/24/2020 4:40 PM
  • Commit: 0b8ce7c1c078eefb4cbc4d7e67ffc02f1f73382d
  • Branch: refs/heads/release/3.x
  • Updates:
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.20124.2

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
09b02a2 
…212.6

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20112.6
@dotnet-maestro

dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (macOS Core), msbuild-pr (Linux Core), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Windows Full), msbuild-pr (Windows Core)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@rainersigwald

rainersigwald commented Feb 13, 2020

Copy link
Copy Markdown
Member

@JohnTortugo, this pulls in your symbol changes, right?

If so, @Forgind, can you please try reverting #5070 on top of this change and validating that all is well (doing an insertion and validating that VS symbol check passes)?

@dotnet-maestro

dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (macOS Core), msbuild-pr (Linux Core), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Windows Full), msbuild-pr (Windows Core)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@Forgind

Forgind commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Started a build here.

PR

It looks like the symbol check failed. @rainersigwald, next steps?

@dotnet-maestro

dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (macOS Core), msbuild-pr (Linux Core), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Windows Full), msbuild-pr (Windows Core)
  • ❌ Standard Merge Policies There are reviews that have requested changes.

Forgind
Forgind suggested changes Feb 13, 2020
View reviewed changes

@Forgind Forgind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking to prevent merge

@JohnTortugo

JohnTortugo commented Feb 13, 2020

Copy link
Copy Markdown

@rainersigwald - Yes, this should contain the fixes.

@dotnet-maestro

dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (macOS Core), msbuild-pr (Linux Core), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Windows Full), msbuild-pr (Windows Core)
  • ❌ Standard Merge Policies There are reviews that have requested changes.

@JohnTortugo

JohnTortugo commented Feb 13, 2020

Copy link
Copy Markdown

The test build: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3469576&view=results and the symbol validation passed: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/229072

@dotnet-maestro

dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (macOS Core), msbuild-pr (Linux Core), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Windows Full), msbuild-pr (Windows Core)
  • ❌ Standard Merge Policies There are reviews that have requested changes.

@Forgind

Forgind commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

The test build: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3469576&view=results and the symbol validation passed: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/229072

The build is right, but the PR was one @benvillalobos started to validate that removing an icon doesn't break anything. Here's the right PR; the symbol check failed.

@dotnet-maestro

dotnet-maestro Bot commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Linux Core), msbuild-pr (macOS Core), msbuild-pr (Windows Core), msbuild-pr (Windows Full)
  • ❌ Standard Merge Policies There are reviews that have requested changes.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
1539741 
…213.5

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20113.5
@rainersigwald

rainersigwald commented Feb 14, 2020 •
edited by Pilchie
Loading

Copy link
Copy Markdown
Member

Symbol check bug and repro steps are at AB#1068393

@dotnet-maestro

dotnet-maestro Bot commented Feb 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: msbuild-pr, msbuild-pr (macOS Mono), msbuild-pr (macOS Core), msbuild-pr (Linux Core), msbuild-pr (Windows Full Release (no bootstrap)), msbuild-pr (Windows Core), msbuild-pr (Windows Full)
  • ❌ Standard Merge Policies There are reviews that have requested changes.

@Forgind Forgind mentioned this pull request Feb 14, 2020
Closed
rainersigwald
rainersigwald approved these changes Feb 20, 2020
View reviewed changes

@rainersigwald rainersigwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can take this even though it doesn't solve the specific symbol problem. We should stay up to date anyway.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20200…
d166a4d 
…224.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.20124.2
@Forgind Forgind merged commit 3a6a5cd into master Feb 25, 2020
@Forgind Forgind deleted the darc-master-b93e3e2a-508b-42fd-8172-36c6b7c0d932 branch February 25, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes
+1 more reviewer
@Forgind Forgind Forgind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Forgind Forgind

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rainersigwald @Forgind @JohnTortugo