Added ability to create CIM files and unpack packages to them #377
Conversation
stephenk-msft
requested review from
jyvenugo,
sarjanas-msft and
wcheng-msft
as code owners
MsixCore/msixmgr/CIMProvider.cpp
Outdated
| { | ||
| std::wcout << "Failed to load createcim.dll. Please confirm the dll is next to this exe." << std::endl; | ||
| return HRESULT_FROM_WIN32(ERROR_MOD_NOT_FOUND); | ||
| } |
There was a problem hiding this comment.
it seems this is repeated for every function you call, maybe use a class to wrap the loadlibrary and have it free in the destructor?
There was a problem hiding this comment.
Created a new class to wrap the loadlibrary - let me know if this isn't what you had in mind.
There was a problem hiding this comment.
yes, that looks better; just because it's in a new class doesn't mean you can't have the output
MsixCore/msixmgr/msixmgr.cpp
Outdated
| hr = MsixCoreLib::UnpackBundle(packageFilePath, unpackDestination, cli.IsApplyACLs(), cli.IsValidateSignature()); | ||
| if (createFile) | ||
| { | ||
| // TO-DO: Add ability to create VHD |
There was a problem hiding this comment.
// TO-DO: Add ability to create VHD [](start = 20, length = 35)
don't push TODOs and commented code.
| if (UuidFromStringW((RPC_WSTR)(cli.GetVolumeId().c_str()), &volumeIdFromString) != RPC_S_OK) | ||
| { | ||
| std::wcout << std::endl; | ||
| std::wcout << "Failed to convert specified volume id {" << volumeIdString << "} to GUID" << std::endl; |
There was a problem hiding this comment.
volumeIdString [](start = 79, length = 14)
can this already have curly braces?
There was a problem hiding this comment.
The expected workflow is that the user would provide a GUID without the curly braces.
Changes
Notes