Merged
Conversation
Collaborator
nibanks
commented
Dec 11, 2019
nibanks
commented
- Cleans up and onboards spinquic to CI.
- Disabled v4 unreachable test on Windows.
- Adds resumption test cases.
- Adds resumption support for schannel.
Collaborator
Author
|
@jkotalik this changes the public API a bit. It renames a variable name. |
Contributor
|
Are the docs update to reflect the changes? |
Collaborator
Author
|
The variable name was not documented yet. So they continue to be as up to date as before. :) |
jkotalik
reviewed
Dec 12, 2019
| cd artifacts/dumps | ||
|
|
||
| # Run spinquic for a while. | ||
| ../bin/spinquic both -timeout:300000 |
Contributor
There was a problem hiding this comment.
Do these kinds of tests run on CI today? How long do they run for? Do they run on PRs?
Collaborator
Author
There was a problem hiding this comment.
We run these types of tests internally. I've picked times that are about equal to other test runs, so they won't increase over all CI time.
jkotalik
reviewed
Dec 12, 2019
|
|
||
| Notes: | ||
|
|
||
| This code uses linear-hashing to increase the table size |
Contributor
There was a problem hiding this comment.
Is this file from somewhere else? Seems like a lot of changes here.
Collaborator
Author
There was a problem hiding this comment.
I did a big refactor of the code.
Contributor
|
Has this PR been already approved internally? |
jkotalik
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.