Add configuration surface for resumption and 0-RTT for server.#481
Merged
Add configuration surface for resumption and 0-RTT for server.#481
Conversation
Collaborator
|
I don't think we need to have a connection specific parameter; just a session layer one. |
nibanks
reviewed
Jun 9, 2020
Comment on lines
+144
to
+149
| // | ||
| // Indicates that this connection has resumption enabled and needs to | ||
| // keep the TLS state and transport parameters until it is done sending | ||
| // resumption tickets. | ||
| // | ||
| BOOLEAN ResumptionEnabled : 1; |
Collaborator
There was a problem hiding this comment.
Do we need this or can we just dynamically read the current setting?
Collaborator
Author
There was a problem hiding this comment.
This will be used to signal when the connection is no longer going to send any more resumption tickets, and thus, when it is safe to clean up the TLS state and the handshake transport parameters.
nibanks
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.