Fix race between causing spurious failure in the ConnectTcp datapath test #5678
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5678 +/- ##
==========================================
+ Coverage 85.57% 85.93% +0.36%
==========================================
Files 60 60
Lines 18663 18663
==========================================
+ Hits 15970 16038 +68
+ Misses 2693 2625 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anrossi
reviewed
Dec 21, 2025
| // otherwise the cleanup might not wait for the rundown. | ||
| // | ||
| AcceptSocketProc->IoStarted = TRUE; | ||
| if (!CxPlatRundownAcquire(&AcceptSocketProc->RundownRef)) { |
Collaborator
There was a problem hiding this comment.
if it fails to acquire the rundown, it means the socket is being shutdown, and the IO should be canceled, and IoStarted should be set to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CxPlatDataPathSocketProcessAcceptCompletioncan race withCxPlatSocketDeleteif the test code delete the socket right after it receive the "accept" callback.CxPlatSocketDeletedoesn't wait on the rundown ref whenIoStartedis not true (I don't know why, and I wonder if we couldn't simply remove that special case, but that is out of scope of this PR).This would allow a socket to be already in the "uninitialzed" state when then end of
CxPlatDataPathSocketProcessAcceptCompletiontries to post the first receive SQE on it.Fixes #5679
Testing
CI. The failure was observed regularly on recent PR CI runs but is not consistent, so we may have to keep an eye for a time.
Documentation
N/A