Conversation
|
LGTM but we need to figure out how to not depend on |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5796 +/- ##
==========================================
- Coverage 85.99% 84.78% -1.21%
==========================================
Files 60 60
Lines 18729 18729
==========================================
- Hits 16106 15880 -226
- Misses 2623 2849 +226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It seems to be the standard way to install perl in CI. I don't think we have a need / reason to not depend on it in our public CI. |
Hmm, maybe the more pertinent but ignorant question is "why do we even use perl?" if the rest of the industry seems not to bother supporting it. In general, we want to take dependencies with both clear support and security policies - if the action is not a first party (GitHub or Microsoft) action, then it becomes a more nuanced decision. |
Perl is needed to build OpenSSL. |
Now it all makes sense! 😆 |
Description
The build CI started to fail with errors like:
https://github.com/microsoft/msquic/actions/runs/22020983438/job/63904220521?pr=5794
This has been fixed in shogo82148/actions-setup-perl#2481.
Update the action to fix the CI.
Testing
CI
Documentation
N/A