-
Notifications
You must be signed in to change notification settings - Fork 31
FIX: Update and publish benchmark script #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a new benchmarking infrastructure to the mssql-python project, adding a benchmarks directory with a comprehensive benchmark script and documentation. The benchmarking system compares performance between pyodbc and mssql_python libraries across various database operations.
- Added comprehensive benchmark script
bench_mssql.pywith 18 different database operation benchmarks - Created detailed README documentation explaining setup, usage, and features of the benchmarking system
- Implemented automated database setup/cleanup with proper error handling and progress reporting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| benchmarks/bench_mssql.py | Complete benchmark script with database operations testing for both pyodbc and mssql_python libraries |
| benchmarks/README.md | Documentation explaining benchmark purpose, setup instructions, and usage with richbench tool |
1f60d0a to
8007b68
Compare
Work Item / Issue Reference
Summary
This pull request introduces a new
benchmarksdirectory with aREADME.mdfile to guide users on how to run database performance benchmarks usingpyodbcandmssql_python. The documentation provides detailed instructions and highlights the key features of the benchmark script.Documentation for Benchmarking:
benchmarks/README.md: Added a comprehensive guide explaining the purpose of benchmarks, setup instructions, and how to run them usingrichbench. The guide also outlines key features of thebench_mssql.pyscript, such as support for various database operations, error handling, and automated setup/cleanup.