Skip to content

Conversation

@gargsaumya
Copy link
Contributor

@gargsaumya gargsaumya commented Jul 23, 2025

Work Item / Issue Reference

AB#38033

GitHub Issue: #<ISSUE_NUMBER>


Summary

This pull request introduces a new benchmarks directory with a README.md file to guide users on how to run database performance benchmarks using pyodbc and mssql_python. The documentation provides detailed instructions and highlights the key features of the benchmark script.

Documentation for Benchmarking:

  • benchmarks/README.md: Added a comprehensive guide explaining the purpose of benchmarks, setup instructions, and how to run them using richbench. The guide also outlines key features of the bench_mssql.py script, such as support for various database operations, error handling, and automated setup/cleanup.

Copilot AI review requested due to automatic review settings July 23, 2025 08:06
@gargsaumya gargsaumya changed the title updated script and adding to github for public FIX: Update benchmarkscript and publish for public Jul 23, 2025
@gargsaumya gargsaumya changed the title FIX: Update benchmarkscript and publish for public FIX: Update benchmark script and publish for public Jul 23, 2025
@github-actions github-actions bot added the pr-size: large Substantial code update label Jul 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a new benchmarking infrastructure to the mssql-python project, adding a benchmarks directory with a comprehensive benchmark script and documentation. The benchmarking system compares performance between pyodbc and mssql_python libraries across various database operations.

  • Added comprehensive benchmark script bench_mssql.py with 18 different database operation benchmarks
  • Created detailed README documentation explaining setup, usage, and features of the benchmarking system
  • Implemented automated database setup/cleanup with proper error handling and progress reporting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
benchmarks/bench_mssql.py Complete benchmark script with database operations testing for both pyodbc and mssql_python libraries
benchmarks/README.md Documentation explaining benchmark purpose, setup instructions, and usage with richbench tool

@gargsaumya gargsaumya changed the title FIX: Update benchmark script and publish for public FIX: Update and publish benchmark script Jul 23, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Jul 23, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Jul 23, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: large Substantial code update labels Jul 24, 2025
@gargsaumya gargsaumya merged commit a8a9ea0 into main Jul 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: large Substantial code update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants