-
Notifications
You must be signed in to change notification settings - Fork 32
DOC: README - Kerberos Dependencies on Linux #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Linux installation documentation and error messages for Kerberos dependencies. The changes improve the setup experience by providing comprehensive dependency lists for various Linux distributions and updating error messages to direct users to documentation.
- Updated README.md with expanded package lists for Alpine, Debian/Ubuntu, RHEL/CentOS/Fedora distributions and added SUSE/openSUSE instructions
- Modified error message in ddbc_bindings.cpp to reference documentation instead of specific package names
- Added Kerberos-related dependencies (krb5-dev, libkrb5-3, libgssapi-krb5-2, krb5-libs) across distributions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Expanded Linux dependency installation instructions with Kerberos packages for multiple distributions |
| mssql_python/pybind/ddbc_bindings.cpp | Updated error message to reference documentation instead of specific package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sumitmsft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment
Work Item / Issue Reference
Summary
This pull request updates installation instructions and error messaging to improve the setup experience for Linux users. The most important changes include expanding the list of required packages in the documentation for various Linux distributions and clarifying error messages to direct users to the documentation for troubleshooting.
Documentation improvements:
README.mdfor Alpine, Debian/Ubuntu, RHEL/CentOS/Fedora, and added instructions for SUSE/openSUSE to ensure all necessary dependencies are installed before runningpip install mssql-python.Error handling improvements:
ddbc_bindings.cppto direct Linux users to the documentation for dependency installation, instead of referencing only thelibltdl7package.