FEAT: Access Token Login #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for access token authentication by enhancing how connection attributes are set before connecting.
- Updates the C++ binding function (SQLSetConnectAttr_wrap) to support various Python value types including sequences.
- Adds an optional attrs_before parameter to Python connection functions to allow pre-connection attribute configuration.
- Updates constants and refactors the connection initialization to apply these attributes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mssql_python/pybind/ddbc_bindings.cpp | Enhances SQLSetConnectAttr_wrap to support multiple Python types and recursive sequence handling. |
| mssql_python/db_connection.py | Introduces an attrs_before parameter in connect to bypass user/password for access token auth. |
| mssql_python/constants.py | Adds the SQL_IS_POINTER constant for pointer-based attribute values. |
| mssql_python/connection.py | Refactors connection initialization and attribute setting to apply pre-connection attributes. |
Closed
bewithgaurav
requested changes
May 14, 2025
bewithgaurav
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.