FEAT: Enforce Level 3 and 4 warnings as errors to adhere to compliance standards. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargsaumya
force-pushed
the
saumya/no-level-3-4-warning
branch
from
ef57050 to
a2e5c9f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tightens MSVC build settings by treating warnings as errors for the ddbc_bindings target.
- Adds
/W4and/WXcompiler flags when using MSVC - Improves code quality enforcement on Windows builds
Comments suppressed due to low confidence (1)
mssql_python/pybind/CMakeLists.txt:290
- The
MSVCCMake variable doesn’t cover clang-cl in MSVC compatibility mode. Consider using a generator expression likeif (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" OR (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC"))to catch both.
if(MSVC)
gargsaumya
force-pushed
the
saumya/no-level-3-4-warning
branch
from
a2e5c9f to
37e3407
Compare
sumitmsft
approved these changes
Jun 16, 2025
bewithgaurav
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a platform-specific enhancement to the build configuration for
ddbc_bindingsin theCMakeLists.txtfile. It adds stricter warning level flags for MSVC to improve code quality.Build configuration improvement:
mssql_python/pybind/CMakeLists.txt: Added a conditional block to apply/W4(warning level 4) and/WX(treat warnings as errors) compiler flags when building with MSVC. This ensures stricter code quality checks for Windows builds.