Merged
Conversation
Updating azure-pipelines to python 3.8 type hints in data_providers Linting errors Another failing test in test_metadata.py Addressing McCabe and Prospector warnings Fixing test breaks in ti_enrich.py and account_summary.py Adding additional McCabe suppressions to deal with diff versions (sometimes McCabe IDs the start of decorated function as the decorator line, in newer versions, it uses the def line) Fixing error caused by msticpy bug in ti_enrich Reverting change to calling SelectAlert since it fails on 1.4.5 and earlier Updating version to 0.2.3 Account summary updates
Fixing deprecated paths in data_providers.py and logon_session_rarity.py
…etwork events Fixed style bug in notebooklet_result.py that made title text invisible in dark mode. Added tests for MDE to test_ip_summary.py
Adding some display for MDE data in ip_summary.py
Fixing import of display timeline Fixing some other broken things
petebryan
approved these changes
May 6, 2022
Contributor
petebryan
left a comment
petebryan
left a comment
There was a problem hiding this comment.
Looks good, getting the information from MDE is definitely more complex than I realized it would be!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.