Merged
Conversation
Contributor
Author
|
Just spotted another issue I will wrap into this PR tomorrow. |
ianhelle
approved these changes
Sep 9, 2022
Contributor
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
Had some minor comments.
Contributor
|
I have PR here that has some important fixes related to loading notebooklets (esp customer-supplied ones) |
Contributor
Author
|
Updated the requirements to the correct value for MSTICPy but is dependent on publication of new MSTICPy version. |
ianhelle
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a number of bugs in the host notebooklets including adding better error handling when expected data isn't present, and correctly hiding or displaying visualizations.
Also includes improvements to data sources used, such as including CommonSecurityLogs for network sources.