Conversation
- Added docs requirements.txt - Updated make file to regenerate API docs each time make is run - Corrected some doc strings in __init__.py and data_providers.py - Adding regenerated API docs
Fixed bokeh 3.x compatibility Fixed a few random test errors due to moving of init_function Added mocks for who_is responses to relevant unittests.
…ticpy Correcting a couple of typos in url_summary Suppressing some mypy issues due to Bokeh typing changes.
…into ianhelle/sphinx-rtd-fixes-2022-09-15 # Conflicts: # msticnb/common.py # msticnb/nb/azsent/host/host_logons_summary.py # msticnb/nb/azsent/url/url_summary.py
petebryan
reviewed
Mar 15, 2023
| msticpy[azure]==2.3.1 | ||
| numpy>=1.17.3 | ||
| pandas>=0.25.3 | ||
| python-dateutil>=2.8.1 |
Contributor
There was a problem hiding this comment.
Think you need to add respx for the unit tests
Fixing calls to ti_lookup - "observable" parameter changed to "ioc" in ip_summary.py, url_summary.py, ti_enrich.py Removing alert summary code to separate function in host_summary.py
Add mock for missed call in test_ip_summary.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of test fixes for msticpy and bokeh compat.
I've also properly mocked ipwhois calls.
It contains an old branch that was just doc updates that was never merged.