Merged
Conversation
This reverts commit d1938f6.
Fixed the first 4 test cases in test_sumologic_driver.py Corrected "url" parameter in Sumologic-DataConnector.ipynb to be "connection_str" (as used in the code) sumologic_driver: - Fixed get_connect_args to properly use the connection_str passed as argument - replaced sys.exit() with exception. sys.exit is a bit drastic. - tidied up long lines and added temporary pylint suppression
Added sumologic to test_pkg_imports.py and import_analyzer.py Added Browshot to mpconfig_defaults.yaml
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…om/microsoft/msticpy into pr/116-sumologic-driver-2021-04-21
test_pkg_imports exception for openpyxl
juju4
added a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
* add Sumologic as backend * fix typo, add performance timer if verbosity>=2 * sumo notebook: fix syntax when using msticpyconfig.yaml, missing dateitme import * PR review (typo, formatting, import...) * remove unused connection_str * exception general+HTTPError, change 1-2 letters variables * pylint review * Revert "remove unused connection_str" This reverts commit b7489372fecb04b19add3c2f8337006bb3bc08e2. * use connection_str as url * add checkinterval option * black reformat * fix logic flow and avoid triggering rate-limiting and always return a message * connected message: add accessid * Moving sumologic to setup.py extras. Fixed the first 4 test cases in test_sumologic_driver.py Corrected "url" parameter in Sumologic-DataConnector.ipynb to be "connection_str" (as used in the code) sumologic_driver: - Fixed get_connect_args to properly use the connection_str passed as argument - replaced sys.exit() with exception. sys.exit is a bit drastic. - tidied up long lines and added temporary pylint suppression * Refactored some of the longer methods in sumologic_driver.py * Added full unit tests for sumologic_driver in test_sumologic_driver.py Added sumologic to test_pkg_imports.py and import_analyzer.py Added Browshot to mpconfig_defaults.yaml * Adding openpyxl dependency for sumologic (test for export to excel is breaking) * Pylint warning in sumologic_driver test_pkg_imports exception for openpyxl Co-authored-by: juju4 <juju4@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement PR for Sumologic driver