Skip to content

Ianhelle/modor url refix 2021 08 04#189

Merged
ianhelle merged 6 commits intomainfrom
ianhelle/modor-url-refix-2021-08-04
Aug 7, 2021
Merged

Ianhelle/modor url refix 2021 08 04#189
ianhelle merged 6 commits intomainfrom
ianhelle/modor-url-refix-2021-08-04

Conversation

@ianhelle
Copy link
Contributor

@ianhelle ianhelle commented Aug 5, 2021

Some unfixed URLs. Changes needed because of mordor paths and metadata changes

@ianhelle ianhelle requested a review from petebryan August 5, 2021 02:04
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ianhelle ianhelle merged commit 17f9704 into main Aug 7, 2021
@ianhelle ianhelle deleted the ianhelle/modor-url-refix-2021-08-04 branch August 7, 2021 01:32
juju4 pushed a commit to juju4/msticpy that referenced this pull request Jun 5, 2022
* Fixing Mordor URL again.

* Fixes to data paths and metadata in mordor driver

* Fixing test paths due to AV isolating file.

* removing explicit identifier from test in test_mordor_driver

* Adding pip install seaborn for notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant