Skip to content

Ianhelle/kql as function 2021 08 04#190

Merged
ianhelle merged 10 commits intomainfrom
ianhelle/kql_as_function-2021-08-04
Aug 9, 2021
Merged

Ianhelle/kql as function 2021 08 04#190
ianhelle merged 10 commits intomainfrom
ianhelle/kql_as_function-2021-08-04

Conversation

@ianhelle
Copy link
Contributor

@ianhelle ianhelle commented Aug 5, 2021

Changed Kqlmagic calls to avoid relying on IPython.run_cell_magic.
Now using kql() function imported from Kqlmagic.

Note: this PR contains a few commits from Mordor fixes branch - these are duplicated.

@ianhelle ianhelle requested a review from petebryan August 5, 2021 02:12
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ianhelle ianhelle merged commit 08c7cf1 into main Aug 9, 2021
@ianhelle ianhelle deleted the ianhelle/kql_as_function-2021-08-04 branch August 9, 2021 22:14
juju4 pushed a commit to juju4/msticpy that referenced this pull request Jun 5, 2022
* Kqlmagic operations called as func vs. IPython magics
Now using Kqlmagic.kql() function in kql_driver. Allows
it to be used from python code.

* Fixing Mordor URL again.

* Fixes to data paths and metadata in mordor driver

* Fixing test paths due to AV isolating file.

* Fixing bug where KQL env var was overwritten

* Only add try_azcli_login if not already set

* Fixing incorrect option format for kqlmagic in kql_driver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants