Merged
Conversation
…ook. Couple of minor fixes for nbwidgets.py
Removing unneeded function from mordor_driver.py Sourcery code refactor in entity.py Deprecating create_ip_record function in ip_utils.py Split wsconfig tests out of test_pkg_config.py Adding test_wsconfig.py. Added new test for couple of utility methods Removing redundant import from test_nbwidgets.py
…sted modules Fixing up paths and removing unneeded imports and other cruft. Merged a few tests into single files - test_entity.py and test_timeline.py
Updating use of tqdm to remove deprecated tqdm_notebook in utility.py
Suppressing mypy warning in azure_ml_tools.py
Fixing aliases element in kql query records Handle aliases as list or string in help
petebryan
previously approved these changes
Sep 9, 2021
…er.py, test_azuredata.py, test_geoip.py,test_azuredatatest_process_tree_utils.py, test_user_config.py
juju4
pushed a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
* Added separate unit test for nbwidgets to cover cases missed in notebook. Couple of minor fixes for nbwidgets.py * Removing deprecated code from utility.py Removing unneeded function from mordor_driver.py Sourcery code refactor in entity.py Deprecating create_ip_record function in ip_utils.py Split wsconfig tests out of test_pkg_config.py Adding test_wsconfig.py. Added new test for couple of utility methods Removing redundant import from test_nbwidgets.py * Moved lots of test files into sub-package folders corresponding to tested modules Fixing up paths and removing unneeded imports and other cruft. Merged a few tests into single files - test_entity.py and test_timeline.py * Re-enabling IP_stack/geoip notebook test in test_geoip.py Updating use of tqdm to remove deprecated tqdm_notebook in utility.py * Adding some debugging output to geoip GeoLite class. Suppressing mypy warning in azure_ml_tools.py * Updating test_geoip.py to use predictable msticpyconfig-test.yaml * Adding debug statement to show config file and partial API key * Typo in last push to geoip.py * Another typo in the debug code in geoip.py * Updating test to restore env var values after test in test_pkg_config.py * More debugging for test_geoip.py Fixing aliases element in kql query records Handle aliases as list or string in help * Fixing some merge errors and test failures in geoip.py, import_analyzer.py, test_azuredata.py, test_geoip.py,test_azuredatatest_process_tree_utils.py, test_user_config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of unit tests.
Added a few more unit tests in some easy-to-cover situations.
A few fixes as a result of the better tests.
You prob only need to review the changes to the msticpy modules (vs. all of the tests)