Merged
Conversation
Fixing a few bugs found during the creation of doc notebooks. Updated several modules with numpy-style docstrings - to allow for auto-documentation
…ities and fix for changes to iocextract defaults. Also doc fix for iocextract.py
…nto DocNotebooks # Conflicts: # tests/test_ioc_extractor.py
Use pandas df search in base64unpack.py instead of iterrows then search. Fixing auditdextract.py to only create process events for EXECVE syscalls. Added code to rename fields if name clash from different sub-records.
pareid
approved these changes
Mar 25, 2019
Contributor
There was a problem hiding this comment.
Looks good to me, only thing I'd comment on is the versioning:
- PyPI seems to be normalising the version number from 0.1.03 to 0.1.3, maybe we should update our version to reflect this?
- We should add a tag to master called "v0.1.3" (I'm happy to do this)
- Add a tag to this branch ahead of merge to master for "v0.1.4"
juju4
pushed a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
* implmenting pylint recommendation * Implementing pylint recommendations * Implementing more pylint recommendations * First set of doc notebooks. Fixing a few bugs found during the creation of doc notebooks. Updated several modules with numpy-style docstrings - to allow for auto-documentation * Fixing failing test by specifying include_paths * Updates to README.md and updates for unit tests to add additional entities and fix for changes to iocextract defaults. Also doc fix for iocextract.py * Adding unit test for auditdextract.py. Use pandas df search in base64unpack.py instead of iterrows then search. Fixing auditdextract.py to only create process events for EXECVE syscalls. Added code to rename fields if name clash from different sub-records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding several doc notebooks.
Started updated docstrings to standard numpy format.
Fixing some bugs found while doing the documentation.