Resourcegraph - Incomplete list returned #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps not the best solution, but it works - running the ResourceGraph driver for "PolicyResources" without the addition returns incomplete list of results, with no obvious reason. Noticed in the portal that not all results for a "PolicyResources"-query contain subscriptionId value, and the missing results correspond to those with "blank" values in the column. By adding a blank string to the list, the expected results were returned.
ianhelle
requested changes
Sep 9, 2022
| self.subscription_ids = [ | ||
| sub.subscription_id | ||
| for sub in self.sub_client.subscriptions.list() # type: ignore | ||
| for sub in self.sub_client.subscriptions.list().append("") # type: ignore |
Contributor
There was a problem hiding this comment.
I think this should be something like:
self.subscription_ids = [
sub.subscription_id
for sub in self.sub_client.subscriptions.list()
]
self.subscription_ids.append("").append() adds an item to an existing list but doesn't return anything.
Also "" is not going to have a "subscription_id" attribute.
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ianhelle
approved these changes
Oct 29, 2022
ianhelle
approved these changes
Nov 4, 2022
Contributor
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ianhelle
added a commit
that referenced
this pull request
Feb 3, 2023
…ll resource graph queries - resource_graph_driver.py
petebryan
added a commit
that referenced
this pull request
Feb 3, 2023
…3-02-02 Reverting PR #496 - Removing blank sub-id from resource graph list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps not the best solution, but it works - running the ResourceGraph driver for "PolicyResources" without the addition returns incomplete list of results, with no obvious reason.
Noticed in the portal that not all results for a "PolicyResources"-query contain subscriptionId value, and the missing results correspond to those with "blank" values in the column.
By adding a blank string to the list, the expected results were returned.