Fix error when latest version 3.0.3 of bokeh is installed #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…to bokeh3support
ianhelle
approved these changes
Feb 22, 2023
ianhelle
requested changes
Feb 22, 2023
Contributor
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
I ran through it a bit too quickly.
Minor things though - I think the class should be function and use of relative imports
Adding mypy to pre-commit Suppressing mypy annotation-unchecked in github action
Contributor
|
/azpipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ianhelle
approved these changes
Feb 23, 2023
Contributor
|
/azpipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Bokeh 3.0.3 (latest).
Details:
If Bokeh 3.0.3 (latest) version installed Graph objects are re-indexed using int keys. Previously when Bokeh 3.0.3 installed users report error: ImportError: cannot import name 'Figure' from 'bokeh.plotting'. This fix is compatible with Bokeh 2.4.3.