Skip to content

NetworkPkg: Reset DHCP Service Binding IO Status on Stop#1620

Merged
makubacki merged 1 commit intomicrosoft:release/202502from
makubacki:networkpkg_pxe_changes
Feb 3, 2026
Merged

NetworkPkg: Reset DHCP Service Binding IO Status on Stop#1620
makubacki merged 1 commit intomicrosoft:release/202502from
makubacki:networkpkg_pxe_changes

Conversation

@makubacki
Copy link
Copy Markdown
Member

@makubacki makubacki commented Jan 28, 2026

Description

Resets DhcpSb->IoStatus on stop to prevent a stale state from
persisting which might impact future operations dependent on
the IO status.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • PXE Boot (TFTP + DHCP)

Integration Instructions

  • N/A

@makubacki makubacki self-assigned this Jan 28, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202502@6f83b17). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/202502   #1620   +/-   ##
================================================
  Coverage                  ?   0.55%           
================================================
  Files                     ?     165           
  Lines                     ?   71955           
  Branches                  ?    1751           
================================================
  Hits                      ?     402           
  Misses                    ?   71546           
  Partials                  ?       7           
Flag Coverage Δ
NetworkPkg 0.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki makubacki force-pushed the networkpkg_pxe_changes branch from 30f815d to eb9579d Compare January 30, 2026 19:22
@makubacki makubacki changed the title NetworkPkg: PXE boot stability improvements NetworkPkg: Reset DHCP Service Binding IO Status on Stop Jan 30, 2026
@makubacki makubacki requested review from apop5, kuqin12 and os-d January 30, 2026 19:49
Resets `DhcpSb->IoStatus` on stop to prevent a stale state from
persisting which might impact future operations dependent on
the IO status.

Co-authored-by: Wenbo Hou <wenbhou@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the networkpkg_pxe_changes branch from eb9579d to b6ac7fc Compare February 3, 2026 01:24
@makubacki makubacki enabled auto-merge (squash) February 3, 2026 01:25
@makubacki makubacki merged commit eb18dc0 into microsoft:release/202502 Feb 3, 2026
30 checks passed
apop5 pushed a commit that referenced this pull request Feb 5, 2026
## Description

Resets `DhcpSb->IoStatus` on stop to prevent a stale state from
persisting which might impact future operations dependent on
the IO status.

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

- PXE Boot (TFTP + DHCP)

## Integration Instructions

- N/A

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Co-authored-by: Wenbo Hou <wenbhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants