NetworkPkg/UefiPxeBcDxe: Initialize IPV4 token in IPV4 branch#1625
Merged
makubacki merged 1 commit intomicrosoft:release/202502from Feb 3, 2026
Merged
Conversation
kuqin12
approved these changes
Jan 31, 2026
apop5
approved these changes
Jan 31, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1625 +/- ##
================================================
Coverage ? 0.55%
================================================
Files ? 165
Lines ? 71959
Branches ? 1755
================================================
Hits ? 402
Misses ? 71550
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`EfiPxeBcStart()` in `PxeBcImpl.c` has condiational code branches for IPV4 and IPV6. - IPV4 branch should use `EFI_IP4_COMPLETION_TOKEN` which is `Private->IcmpToken`. - IPV6 branch should use `EFI_IP6_COMPLETION_TOKEN` which is `Private->Icmp6Token`. Right now, the IPv4 branch incorrectly initializes `Private->Icmp6Token` to `EFI_NOT_READY`. That is changed to `Private->IcmpToken`. Co-authored-by: Wenbo Hou <wenbhou@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
networkpkg_pxebcimpl_ipv4_token_fix
branch
from
6b75228 to
67194f7
Compare
apop5
pushed a commit
that referenced
this pull request
Feb 5, 2026
## Description `EfiPxeBcStart()` in `PxeBcImpl.c` has condiational code branches for IPV4 and IPV6. - IPV4 branch should use `EFI_IP4_COMPLETION_TOKEN` which is `Private->IcmpToken`. - IPV6 branch should use `EFI_IP6_COMPLETION_TOKEN` which is `Private->Icmp6Token`. Right now, the IPv4 branch incorrectly initializes `Private->Icmp6Token` to `EFI_NOT_READY`. That is changed to `Private->IcmpToken`. - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested - PXE boot with server setup on a separate device (TFTP + DHCP) ## Integration Instructions - N/A Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Co-authored-by: Wenbo Hou <wenbhou@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EfiPxeBcStart()inPxeBcImpl.chas condiational code branches for IPV4 and IPV6.EFI_IP4_COMPLETION_TOKENwhich isPrivate->IcmpToken.EFI_IP6_COMPLETION_TOKENwhich isPrivate->Icmp6Token.Right now, the IPv4 branch incorrectly initializes
Private->Icmp6TokentoEFI_NOT_READY. That is changed toPrivate->IcmpToken.How This Was Tested
Integration Instructions