[CHERRY-PICK] Adding TPM over FFA ACPI table revision fix#1786
Merged
kuqin12 merged 3 commits intomicrosoft:release/202511from May 6, 2026
Merged
[CHERRY-PICK] Adding TPM over FFA ACPI table revision fix#1786kuqin12 merged 3 commits intomicrosoft:release/202511from
kuqin12 merged 3 commits intomicrosoft:release/202511from
Conversation
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/25455647301 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1786 +/- ##
================================================
Coverage ? 1.59%
================================================
Files ? 160
Lines ? 37730
Branches ? 172
================================================
Hits ? 601
Misses ? 37129
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…b from dependencies Current implementation of Tcg2AcpiFfa does not rely on the interfaces defined in `Tcg2PhysicalPresenceLib`. Carrying it in the module inf could bring in unnecessary external dependencies and cause loading orders to change. This change removes the dependency from the current "LibraryClasses" list. Signed-off-by: Kun Qin <kun.qin@microsoft.com> (cherry picked from commit c60df38f10716f60eab4c617623e5c124b8cc2f7)
Current Tcg2AcpiFfa will populate the partition ID in byte order of big- endian. This conflicts with the TCG ACPI Specification, which specifies the byte-order to be little-endian. This change corrects the byte order population process by replacing the platform parameter byte array with MdePkg defined structure. Signed-off-by: Kun Qin <kun.qin@microsoft.com> (cherry picked from commit a270773cce476ed0be9eb9b6370164d1d1fb0796)
…M2 table Given the start method of FFA is only introduced in revision 5 of the TCG ACPI specification. A TPM2 table with FFA start method and lower than 5 revision should not be allowed. This change updates the checks for revision PCD and removed a few conditions based on new revision 5 assumptions. Signed-off-by: Kun Qin <kun.qin@microsoft.com> (cherry picked from commit f1fc41cff2a2022e67da3f9f525f9087cf2de507)
apop5
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates the TPM2 table when using TPM over FFA to support the functionality.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested on the latest Windows OS and booted to desktop with expected event log entries.
Integration Instructions
gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev|5.