[Rebase & FF] Fix Partition ID being used for FFA_RUN calls#1827
Merged
Conversation
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/28066724054 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1827 +/- ##
=================================================
Coverage ? 2.25%
=================================================
Files ? 1637
Lines ? 420611
Branches ? 5035
=================================================
Hits ? 9469
Misses ? 411060
Partials ? 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kuqin12
force-pushed
the
fix_part_id
branch
2 times, most recently
from
854482a to
9a631df
Compare
kuqin12
changed the title
cfernald
approved these changes
Jun 22, 2026
cfernald
approved these changes
Jun 23, 2026
apop5
approved these changes
Jun 23, 2026
kuqin12
commented
Jun 23, 2026
kuqin12
force-pushed
the
fix_part_id
branch
3 times, most recently
from
f7e5f83 to
a81d042
Compare
The direct message arguments stripped off the header, making the underlying FF-A function interface to lose information when it comes to certain return code, i.e. FFA_YIELD and FFA_INTERRUPT. This change adds back the header field for this purpose so that the callers can decide how to act on the corresponding return codes. It then populates the header field for this purpose in FFA direct message functions so that the callers can decide how to act on the corresponding return codes. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
As the FFA function now returns the target ID properly, instead of hardcoding the FFA_RUN target ID being the STMM, we use the parsed ID to issue the FFA_RUN. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
As the FFA function now returns the target ID properly, instead of hardcoding the FFA_RUN target ID being the TPM SP, we use the parsed ID to issue the FFA_RUN. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
apop5
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of FFA run invocation always uses the original partition ID as the input for FFA_RUN. However, this is problematic when the partitions are chain loading the direct request 2 functions and the partitions are interruptible. In that case, the caller should FFA_RUN to the partition specified in w1.
Then the w1 information was eaten in the case of direct request calls, because we only exposed the payload to the callers.
How This Was Tested
This is tested on ARM virt and physical platform.
Integration Instructions
N/A