Enable ARM64 build for UefiExt.dll#66
Merged
cfernald merged 3 commits intomicrosoft:mainfrom Oct 4, 2024
Merged
Conversation
VivianNK
approved these changes
Oct 4, 2024
os-d
approved these changes
Oct 4, 2024
Contributor
os-d
left a comment
os-d
left a comment
There was a problem hiding this comment.
LGTM. My only question is whether we really care to publish both debug and release builds for both archs. I'd assume release only is fine. If you wanted a debug build presumably you'd be building it yourself to make some change. But no need to hold up this PR for, mostly curious
Contributor
Author
We build both but only release gets uploaded for the reason you mentioned. Debug build really provides very little benefit for this binary anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an arm64 build for the UefiExt windbg debugger extension.
How This Was Tested
N/A
Integration Instructions
N/A