AdvLoggerPkg: Check for migrated buffer on ReadyToLock notification#833
Merged
makubacki merged 1 commit intomicrosoft:release/202502from Feb 23, 2026
Merged
Conversation
Add a check to ReadyToLock to ensure the SMM core logger is moved to the migrated logger buffer if it was not already. Also, do not look for a new logger buffer after ReadyToLock, to avoid SMM moving to a new buffer after the trust boundary transition. This updates both the Traditional MM and Standalone MM AdvLoggerAccessLib instances for consistency. Also ensures all calls to check for a new logger are gated on PcdAdvancedLoggerFixedInRAM to avoid unnecessary checks when the logger won't be migrated. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/202502 #833 +/- ##
================================================
Coverage ? 4.63%
================================================
Files ? 36
Lines ? 4269
Branches ? 276
================================================
Hits ? 198
Misses ? 4069
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
os-d
approved these changes
Feb 21, 2026
apop5
approved these changes
Feb 22, 2026
apop5
pushed a commit
that referenced
this pull request
Feb 25, 2026
…833) ## Description 1. Adds a ReadyToLock handler to ensure that any buffer migration that may not have occurred prior to that point happens at ReadyToLock. 2. Aligns Traditional MM and Standalone MM code on the ReadyToLock boundary. 3. Also ensures all calls to check for a new logger are gated on PcdAdvancedLoggerFixedInRAM to avoid unnecessary checks when the logger won't be migrated. - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested - Boot Traditional SMM virtual machine platform to Windows with change - Boot Standalone MM virtual machine platform to Windows with change - Boot Intel platform to Windows with change (Traditional and Standalone MM) - Dump log at EFI shell - Dump log uses the latest decode Python script in Windows ## Integration Instructions - N/A Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How This Was Tested
Integration Instructions