Move LSP installs to ~/.multilspy/lsp/, add server_binary and server_install_dir config#137
Merged
LakshyAAAgrawal merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Conversation
…install_dir config Language servers were downloading binaries into the Python package's site-packages directory (os.path.dirname(__file__) + "/static/"). This is unconventional, breaks with read-only package installations, and causes issues when multiple environments share the same package. Changes: - Default install location is now ~/.multilspy/lsp/<server_name>/ via MultilspySettings.get_server_install_directory() - Add config.server_binary: skip download entirely and use a pre-installed binary at the given path - Add config.server_install_dir: override the default install location for server artifacts - Fix microsoft#131: check executable existence instead of directory existence to handle interrupted downloads gracefully All 10 language servers updated consistently: - Servers that download binaries (rust-analyzer, dart, clangd, omnisharp, typescript, jdtls, kotlin) use the new install dir - Servers that use system tools (jedi, gopls, solargraph) respect server_binary to allow custom paths Fixes microsoft#136, fixes microsoft#131, fixes microsoft#109
c0a6dc4 to
604631a
Compare
LakshyAAAgrawalP
approved these changes
Apr 10, 2026
Collaborator
Author
|
Credit to @jsimonrichard who proposed the same @jsimonrichard — thank you for the original idea and implementation! This PR supersedes #125 with a broader scope. Would you like to review the approach here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Language servers were downloading binaries into the Python package's
site-packagesdirectory (os.path.dirname(__file__) + "/static/"). This is unconventional —site-packagesisn't meant to be writable at runtime — and breaks with read-only package installations.New config options
Changes
~/.multilspy/lsp/<server_name>/instead of<package>/static/config.server_binary: skip download entirely, use a pre-installed binary at the given pathconfig.server_install_dir: override the install location for server artifactsserver_binaryserver_install_dir~/.multilspy/lsp/RustAnalyzer/~/.multilspy/lsp/dart-language-server/~/.multilspy/lsp/clangd/""~/.multilspy/lsp/OmniSharp/--stdio~/.multilspy/lsp/ts-lsp/~/.multilspy/lsp/EclipseJDTLS/~/.multilspy/lsp/KotlinLanguageServer/Fixes #136, fixes #131, fixes #109