Skip to content

Implement WifiAccessPointEnable#203

Merged
abeltrano merged 15 commits intodevelopfrom
apenableaggregate
Mar 3, 2024
Merged

Implement WifiAccessPointEnable#203
abeltrano merged 15 commits intodevelopfrom
apenableaggregate

Conversation

@abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

*Allow access points to be enabled.

Technical Details

  • Add impl functions for each API to allow usage in smaller blocks.
  • Add helper to extract strongly typed frequency bands from Dot11AccessPointConfiguration.
  • Add helpers for obtaining an IAccessPoint and IAccessPointController in a consistent way.
  • Fix SetSssid -> SetSsid.

Test Results

  • All unit tests pass.

Reviewer Focus

  • None

Future Work

  • Enforce AKM and cipher suite settings on enable. IAccessPointController needs to be expose functions for configuring security.
  • Convert WifiAccessPointDisable to use an impl function of the new pattern.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 3, 2024 14:19
@abeltrano abeltrano merged commit fcbc3a7 into develop Mar 3, 2024
@abeltrano abeltrano deleted the apenableaggregate branch March 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant