Fix intermittent failure in DataStreamUpload

[corbin-phipps]

Type

• Bug fix
• Feature addition
• Feature update
• Documentation
• Build Infrastructure

Side Effects

• Breaking change
• Non-functional change

Goals

Fixes an intermittent failure in the unit tests for DataStreamUpload where the number of data blocks received by the server was greater than the number of blocks sent.

This is because inside NextWrite(), m_numberOfDataBlocksToWrite was being decremented after the call to StartWrite(), but StartWrite() calls NextWrite(), which would sometimes use the old value of m_numberOfDataBlocksToWrite, thus writing additional data.

Technical Details

• Moved decrement line to before call to StartWrite() in NextWrite() function for both client reactors DataStreamWriter and DataStreamReaderWriter.

Test Results

Ran DataStreamUpload API unit tests 20 times in a row, 100% pass. Other tests pass too.

Reviewer Focus

None.

Future Work

None.

Checklist

• Build target all compiles cleanly.
• clang-format and clang-tidy deltas produced no new output.
• Newly added functions include doxygen-style comment block.