Skip to content

Fix some memory access issues#221

Merged
abeltrano merged 4 commits intodevelopfrom
memfixes
Mar 14, 2024
Merged

Fix some memory access issues#221
abeltrano merged 4 commits intodevelopfrom
memfixes

Conversation

@abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Fix use-after-free instances.
  • Fix stack buffer overflow instances.

Technical Details

  • Avoid calling object destructors explicitly in tests, since this will result in it being called twice, causing use-after-free bugs.
  • Fix off-by-1 array size being passed to nla_parse causing a stack buffer overflow.

Test Results

  • All unit tests pass with clean ASAN output.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 14, 2024 02:45
@abeltrano abeltrano merged commit 410f937 into develop Mar 14, 2024
@abeltrano abeltrano deleted the memfixes branch March 14, 2024 15:37
@abeltrano abeltrano mentioned this pull request Mar 16, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant