Skip to content

Allow specifying authentication algorithm names and frequency bands with WifiAccessPointEnable API#235

Merged
abeltrano merged 3 commits intodevelopfrom
apenableargs2
Mar 20, 2024
Merged

Allow specifying authentication algorithm names and frequency bands with WifiAccessPointEnable API#235
abeltrano merged 3 commits intodevelopfrom
apenableargs2

Conversation

@abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Mar 20, 2024

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Allow configuring authentication algorithms via WifiAccessPointEnable.
  • Allow configuring frequency bands via WifiAccessPointEnable.

Technical Details

  • Add cli option --freq (with aliases) to specify frequency bands with wifi enable command.
  • Add cli option --auth (with aliases) to specify frequency bands with wifi enable command.

Test Results

  • All unit tests pass.
  • Validated wi-fi access point reflects configured bands and authentication algorithms out-of-band with hostapd following these commands:
shadowfax@mrstux:~/src/microsoft/netremote-cmake/build/dev-linux$ ./src/linux/tools/cli/Debug/netremote-cli -s 127.0.0.1 wifi enable wls1 --freqs 2.4 5 --auth open shared --phy ac
Executing command WifiAccessPointEnable

Reviewer Focus

  • None

Future Work

Describe any future work that is required as a result of this change. Eg.

  • Add AKMs and security protocols to Dot11AccessPointConfiguration, and implementation to configure them.
  • Add cli options to specify pairwise ciphers.
  • Improve cli help text for wifi enable arguments.

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner March 20, 2024 16:41
@abeltrano abeltrano merged commit 251b187 into develop Mar 20, 2024
@abeltrano abeltrano deleted the apenableargs2 branch March 20, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant