Fix parsing quoted empty arg in response file#185
Merged
Conversation
vmoroz
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a build break for .NET Framework 4.x, where the response file has
--packs ""(because .NET Framework doesn't have the concept of "targeting packs"). The empty quoted argument broke the parser. I'm not sure how that bug got past a PR build originally.This fix had been included in #180 but that PR is taking longer to finish, and is unrelated anyway. I'm splitting out this fix to unblock builds of other PRs.
Also I'm adding the generated
.rspfile to the build logs archive, to help with diagnosing future issues related to this area.