Skip to content

Update example to SK 1.1, fix TS generator and marshaller bugs#191

Merged
jasongin merged 7 commits intomainfrom
dev/jasongin/sk
Jan 19, 2024
Merged

Update example to SK 1.1, fix TS generator and marshaller bugs#191
jasongin merged 7 commits intomainfrom
dev/jasongin/sk

Conversation

@jasongin
Copy link
Copy Markdown
Member

@jasongin jasongin commented Jan 19, 2024

  • examples/semantic-kernel:
    • Update Microsoft.SemanticKernel package reference to 1.1.0
    • Update JS code for SK API changes.
  • TS generator fixes:
    • Improve the logic for merging nuget package references with system assembly references.
    • Omit explicit interface implementations for value types (as was already done for classes).
    • Omit members with pointer parameter types.
    • Convert <see cref="..."/> to JSDoc {@link ...}
  • Marshalling fixes:
    • Fix an exception caused by certain kinds of circular references among exported types.
    • Enable marshalling primitive JS value types to .NET object type. Necessary to support some SK APIs such as KernelArguments(IDictionary<string, object?> source) where the expectation is a JS string value in a Map should get marshalled to a NET string value in the dictionary.
  • Tracing improvements:
    • Automatically turn on tracing when a debugger is attached.
    • Enable callback tracing for getters, setters, and methods. Previously the callback tracing only worked for regular functions.

Copy link
Copy Markdown
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasongin jasongin merged commit 3eb943b into main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants